Changes

Summary

  1. kola: refactor and add support for warn: true tests (details)
  2. kola: specify action to runKola helper (details)
  3. kola: use `=` for options with values (details)
  4. checkoutToDir: Recurse submodules (details)
Commit 541fc66d3d3631b6969954ade4adb45eed632e8e by Dusty Mabe
kola: refactor and add support for warn: true tests

This commit refactors the arguments and error handling for `kola`
into a runKola closure to make it easier to manage. Most calls in
this file use mostly the same arguments, so this is a nice cleanup.

This commit also adds the `--on-warn-failure-exit-77` option [1]
and adds handling to mark a test as `warn()` if that happens versus
the typical `error()`.

[1] https://github.com/coreos/coreos-assembler/pull/3551
The file was modified vars/kola.groovy (diff)
Commit a17c01ce83404d0008490db8d9ee107925b397a1 by Dusty Mabe
kola: specify action to runKola helper

Right now in the upgrade case we end up with `cosa kola run --upgrades`
and that doesn't quite pass through everything right:

```
+ cosa kola run --rerun --allow-rerun-success=tags=needs-internet --build=39.20230823.92.0 --output-dir=/home/jenkins/agent/workspace/kola-gcp/tmp/kola-UJ7JH/kola-upgrade --on-warn-failure-exit-77 --arch=x86_64 -p=gcp --gcp-json-key=**** --gcp-project=fedora-coreos-testing --upgrades

kola --build 39.20230823.92.0 run --rerun --allow-rerun-success=tags=needs-internet --on-warn-failure-exit-77 --arch=x86_64 -p=gcp --gcp-json-key=**** --gcp-project=fedora-coreos-testing --output-dir /home/jenkins/agent/workspace/kola-gcp/tmp/kola-UJ7JH/kola-upgrade --qemu-image-dir tmp/kola-qemu-cache -v --find-parent-image

Error: unknown flag: --qemu-image-dir
```

We need the ultimate command to be `kola run-upgrade`. Let's add the
action we want as an argument to the runKola helper.
The file was modified vars/kola.groovy (diff)
Commit 950521da1224dfaccdbbc4d37985728d2b091c81 by Dusty Mabe
kola: use `=` for options with values

The way cosa kola parses things and then passes it on to kola is
a mess. Let's remove the spaces so we can make sure the value doesn't
get separated from the option when it's processed.
The file was modified vars/kola.groovy (diff)
Commit 1a7a4ba03d286d146395cb6c5310519a4a04e038 by Jonathan Lebon
checkoutToDir: Recurse submodules

Prep for adding a git submodule to fedora-coreos-config.
The file was modified vars/checkoutToDir.groovy (diff)